serialize maps and lists when passed to echo #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| defp serialize(list) when is_list(list), | ||
| do: Poison.encode!(list) | ||
| defp serialize(val), | ||
| do: "#{val}" |
There was a problem hiding this comment.
I'd just call to_string(val) directly, instead of doing an unnecessary string interpolation.
| # we might get should implement 'to_string'. | ||
| defp serialize(map) when is_map(map), | ||
| do: Poison.encode!(map) | ||
| defp serialize(list) when is_list(list), |
There was a problem hiding this comment.
If you change the signature to
serialize(arg) when is_map(arg) or is_list(arg)you can do it in one function head instead of two. It also makes the explanatory comments above unnecessary, since they are saying exactly what the code is saying.
|
Also, tests for this new behavior would be good. |
christophermaier
approved these changes
Sep 28, 2016
mpeck
force-pushed
the
peck/echo-serialize
branch
from
3cfce3f
to
3bee79a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
echo was causing Cog to crash whenever it received a value that didn't implement
to_string, ie maps and lists. This change serializes those types withPoison.encode!.resolves #981