Added support for centralized dynamic config #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Use managed dynamic configuration | ||
| # Requires dynamic_config_root | ||
| # Environment variable: RELAY_MANAGED_DYNAMIC_CONFIG |
There was a problem hiding this comment.
We'll need to add this to the doc site: http://docs.operable.io/docs/relay-environment-variables
* Made the dynamic config refresh interval configurable * Immediately update dynamic config when the DCU starts to reduce update propagation latencies * Cleaned up interval reporting phrasing in general
| defer dcu.refreshTimer.Reset(refreshInterval) | ||
| var envelope messages.DynamicConfigsResponseEnvelope | ||
| decoder := json.NewDecoder(bytes.NewReader(payload)) | ||
| decoder.UseNumber() |
There was a problem hiding this comment.
One day, we should try and pull all the JSON decoding into a module so we don't have to keep repeating this same song and dance... 😦 . I'm afraid one day we're going to add something new and forget about this little wrinkle.
| func (dcu *DynamicConfigUpdater) loop() { | ||
| <-dcu.control | ||
| dcu.refreshTimer.Stop() | ||
| dcu.conn.Disconnect() |
There was a problem hiding this comment.
How does this loop?
kevsmith
force-pushed
the
kevsmith/central-dyn-config
branch
from
d775b90
to
5e6433a
Compare
|
👍 |
kevsmith
force-pushed
the
kevsmith/central-dyn-config
branch
from
ae58f69
to
b54815a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to get review on the code early while I'm working on test coverage.