Add support for Markdown paragraph & improve newline behavior #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 28, 2016 16:03
Added `paragraph` nodes to tests. Also dealt with whitespace parsing ripple effects created by introduction of `paragraph`.
- Fixed text node consolidation - Removed unecessary newline filter passes - Traverse entire AST tree, including nested children when inserting newline nodes into text nodes
Newlines inside paragraphs will generate hard line breaks. This is a departure from "standard" Markdown which requires an invisible delimiter (two spaces followed by a newline) for the same behavior. See recent greenbar_markdown commits for the rationale behind this decision.
kevsmith
changed the title
christophermaier
approved these changes
Dec 6, 2016
kevsmith
force-pushed
the
kevsmith/paragraph-children
branch
from
0fc29eb
to
c42b458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newlines inside paragraphs will generate hard line breaks. This is a departure from "standard" Markdown which requires an invisible delimiter (two spaces followed by a newline) for the same behavior.
See operable/greenbar_markdown#7