Merge pull request #51 from operable/nmohoric/not_in_bundle

Improve error message for missing fully qualified command
operable · Aug 28, 2017 · c5c9094 · c5c9094
2 parents 3f153fc + bdb9637
commit c5c9094
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/piper/command/ast/invocation.ex b/lib/piper/command/ast/invocation.ex
@@ -74,8 +74,8 @@ defmodule Piper.Command.Ast.Invocation do
               throw SemanticError.new(entity, {:ambiguous, bundles})
             {:error, :not_found} ->
               :not_found
-            {:error, {:not_in_bundle, _}} ->
-              :not_found
+            {:error, {:not_in_bundle, name}} ->
+              throw SemanticError.new(entity, {:not_in_bundle, name})
             {:error, error} ->
               throw SemanticError.new(entity, error)
           end

diff --git a/test/command/parser/parser_test.exs b/test/command/parser/parser_test.exs
@@ -204,7 +204,7 @@ defmodule Parser.ParserTest do
 
   test "commands not in the requested bundle fail resolution" do
     {:error, message} = Parser.scan_and_parse("not_in_bundle", TestHelpers.parser_options())
-    assert message == "Command 'not_in_bundle' not found in any installed bundle."
+    assert message == "Bundle 'bundle1' doesn't contain a command named 'not_in_bundle'."
   end
 
   test "splicing aliases into parse tree" do