Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding a "light" cluster #419

Closed
larsks opened this issue Mar 23, 2021 · 8 comments · Fixed by #423
Closed

Onboarding a "light" cluster #419

larsks opened this issue Mar 23, 2021 · 8 comments · Fixed by #423

Comments

@larsks
Copy link
Contributor

larsks commented Mar 23, 2021

We've recently deployed an OCP 4.7 bare metal cluster for the Curator project. I'd like to manage some aspects of the cluster through this repository (e.g., the default ingress certificate, the connection with the SSO environment, etc), but there will be other cluster admins who will be "doing their own thing". The overlay configuration would be minimal, probably something like:

resources:
  - ../../../base/clusterrolebindings/cluster-admins-rb
  - ../../../base/groups/cluster-admins
  - ../../../base/ingresscontrollers/default
  - ../../../base/oauths/cluster
  - ../../../base/subscriptions/web-terminal

Does this seem like a reasonable plan?

@HumairAK
Copy link
Member

This sounds reasonable to me -- did you want these resources managed by argocd as well? or just git tracked?

@larsks
Copy link
Contributor Author

larsks commented Mar 23, 2021

Oh, ideally using argocd.

@tumido
Copy link
Member

tumido commented Mar 23, 2021

Sounds good to me. If you want to manage it via argocd, I'd suggest to import it to our ACM which will take care of the ArgoCD setup

@HumairAK
Copy link
Member

HumairAK commented Mar 23, 2021

I'd suggest to import it to our ACM which will take care of the ArgoCD setup

@larsks let us know if this is something you'll be doing, otherwise we will need an SA sitting in this new cluster with cluster admin that argocd can use to login.

@larsks
Copy link
Contributor Author

larsks commented Mar 23, 2021

We installed it using ACM (https://multicloud-console.apps.moc-infra.massopen.cloud/multicloud/clusters/curator/overview), but if there's any specific metadata we need to set that says "we're going to manage this using argocd", we didn't set that.

@tumido
Copy link
Member

tumido commented Mar 23, 2021

Just update the KlusterletAddonConfig with:

spec:
  applicationManager:
    argocdCluster: true

And you're all set 👍

@tumido
Copy link
Member

tumido commented Mar 23, 2021

That reminds me, until ACM BZ 1939096 is resolved, we should probable reserve the namespaces which are created by ACM for the managed clusters in this repo so we don't accidentally touch it...

@tumido
Copy link
Member

tumido commented Mar 23, 2021

@larsks additionally to that you want to create a similar ArgoCD app for the curator:

https://github.com/operate-first/argocd-apps/blob/main/envs/moc/zero/cluster-management/cluster-resources.yaml

And create app of apps:
https://github.com/operate-first/continuous-deployment/blob/master/manifests/overlays/moc-infra/applications/app-of-apps-infra.yaml

@HumairAK I wonder, can we move the app of apps to the argocd-apps repo? So adding a cluster would be only PRs against 2 repos, instead of 3?

larsks added a commit to larsks/argocd-apps that referenced this issue Mar 23, 2021
larsks added a commit to larsks/continuous-deployment that referenced this issue Mar 23, 2021
sesheta pushed a commit that referenced this issue Mar 23, 2021
sesheta pushed a commit to operate-first/continuous-deployment that referenced this issue Mar 23, 2021
sesheta pushed a commit to operate-first/argocd-apps that referenced this issue Mar 23, 2021
harshad16 pushed a commit to harshad16/argocd-apps that referenced this issue May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants