Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give prometheus-ai group access to thanos metrics #1378

Merged
merged 1 commit into from Nov 29, 2021

Conversation

4n4nd
Copy link
Contributor

@4n4nd 4n4nd commented Nov 29, 2021

This PR can be used as an example PR in the docs

Related operate-first/support#454 (comment)

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2021
@4n4nd 4n4nd requested review from HumairAK and removed request for anishasthana November 29, 2021 19:02
Copy link
Member

@HumairAK HumairAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
@sesheta
Copy link
Member

sesheta commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@HumairAK HumairAK merged commit 857e473 into operate-first:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants