Meta labels added to the project namespace manifests #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
4n4nd
reviewed
Mar 3, 2022
HumairAK
reviewed
Mar 3, 2022
4n4nd
reviewed
Mar 8, 2022
cluster-scope/base/core/namespaces/opf-observatorium/namespace.yaml
Outdated
Show resolved
Hide resolved
4n4nd
suggested changes
Mar 16, 2022
cluster-scope/base/core/namespaces/opf-jupyterhub/namespace.yaml
Outdated
Show resolved
Hide resolved
cluster-scope/base/core/namespaces/opf-observatorium/namespace.yaml
Outdated
Show resolved
Hide resolved
These labels will store project information which will be used in the Workload Dashboard Labels: - Owner of project (group) - The issue which the project/workload was onboarded - A link the projects documentation
bryanmontalvan
force-pushed
the
workload-labels
branch
from
bcfa477
to
cad4a36
Compare
|
@4n4nd Fixed the links and rebased 👍 |
|
/test all |
sesheta
added
the
approved
sesheta
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 4n4nd, HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
larsks
reviewed
Mar 17, 2022
| @@ -5,5 +5,8 @@ metadata: | |||
| annotations: | |||
| openshift.io/display-name: "Openshift-ACME Controller" | |||
| openshift.io/requester: operate-first | |||
| op1st/project-owner: operate-first | |||
| op1st/onboarding-issue: "https://github.com/operate-first/support/issues/237" | |||
| op1st/docs: "https://www.operate-first.cloud/apps/content/acme/README.html?highlight=acme" | |||
There was a problem hiding this comment.
I don't think you want the highlight=acme in this url.
This was referenced Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Related #1661
Description:
These labels will store project information which will be used in the Workload Dashboard.
Labels:
Note: