Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zero cluster to 4.7.2 #421

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Upgrade zero cluster to 4.7.2 #421

merged 1 commit into from
Mar 29, 2021

Conversation

larsks
Copy link
Contributor

@larsks larsks commented Mar 23, 2021

Update the zero cluster to 4.7.2.

The ClusterVersion resource includes a clusterID attribute that I have omitted from this update, since if we were to reinstall the cluster the ID would be different.

@sesheta sesheta requested review from 4n4nd and HumairAK March 23, 2021 13:41
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 23, 2021
@HumairAK
Copy link
Member

@larsks should we announce this ahead of time w/ a date/time set, before attempting to deploy this?

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold until we're ready

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@larsks
Copy link
Contributor Author

larsks commented Mar 23, 2021

@HumairAK I think we should, yes.

Closes operate-first/SRE#225
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@larsks
Copy link
Contributor Author

larsks commented Mar 23, 2021

How about we schedule the upgrade for Monday (3/29) morning?

@tumido
Copy link
Member

tumido commented Mar 23, 2021

@larsks sounds good to me 👍 Yep, let's do it

Copy link
Member

@HumairAK HumairAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 29, 2021
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sesheta
Copy link
Member

sesheta commented Mar 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link
Member

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2021
@HumairAK HumairAK merged commit 125849e into operate-first:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants