Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

add prow deployment and its cluster-admin level prereqs #37

Merged
merged 2 commits into from
Jan 20, 2021
Merged

add prow deployment and its cluster-admin level prereqs #37

merged 2 commits into from
Jan 20, 2021

Conversation

goern
Copy link
Member

@goern goern commented Jan 20, 2021

Signed-off-by: Christoph Görn goern@redhat.com

@goern
✨ add prow deployment and its cluster-admin level prereqs
14b9fbc 
Signed-off-by: Christoph Görn <goern@redhat.com>
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2021
@goern goern requested a review from tumido January 20, 2021 11:38
@goern goern changed the title add prow deployment and its cluster-admin level prereqs [WIP] add prow deployment and its cluster-admin level prereqs Jan 20, 2021
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2021
tumido
tumido reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goern do you want to deploy this app in MOC only (1) or should it be possible to deploy it in other clusters as well (2)?

If 1) please add the ci-prow.yaml to the resources in kustomization.yaml

If 2) please move the Applications to base and overlay the spec.source.path in the target overlays. Take a look at the Argo application for example (base and MOC overlay patch

overlays/moc/operate-first/ci-prow.yaml Outdated Show resolved Hide resolved
@goern goern mentioned this pull request Jan 20, 2021
Closed
@goern
incorporate comments from @tumido
fe7819e 
Signed-off-by: Christoph Görn <goern@redhat.com>
@goern goern added this to In progress in Master Board via automation Jan 20, 2021
@goern
Copy link
Member Author

goern commented Jan 20, 2021

This is part of #34

@goern goern changed the title [WIP] add prow deployment and its cluster-admin level prereqs add prow deployment and its cluster-admin level prereqs Jan 20, 2021
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2021
tumido
tumido approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@goern
Copy link
Member Author

goern commented Jan 20, 2021

uhmn.... two approvers?! :/

@tumido
Copy link
Member

tumido commented Jan 20, 2021

Yes! Because we need more eyes on things. We're too old and too senile for a single reviewer anymore. 😄

@4n4nd
Copy link

4n4nd commented Jan 20, 2021 •
edited

@goern if this is an app sourced from the thoth-station org, maybe it should be in the thoth directory?

edit: by org I mean, it is located with the other thoth apps

@goern
Copy link
Member Author

goern commented Jan 20, 2021

but its supporting operate-first ci/cd pipelines in general...

@sesheta
Copy link
Member

sesheta commented Jan 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit e3ceb1d into operate-first:main Jan 20, 2021
Master Board automation moved this from In progress to January 2021 Jan 20, 2021
@goern goern mentioned this pull request Jan 21, 2021
Closed
harshad16 pushed a commit to harshad16/argocd-apps that referenced this pull request Jan 26, 2021
@goern @harshad16
add prow deployment and its cluster-admin level prereqs (operate-firs…
65700ca 
…t#37)

* ✨ add prow deployment and its cluster-admin level prereqs

Signed-off-by: Christoph Görn <goern@redhat.com>

* incorporate comments from @tumido

Signed-off-by: Christoph Görn <goern@redhat.com>
harshad16 pushed a commit to harshad16/argocd-apps that referenced this pull request Jan 31, 2021
@goern @harshad16
add prow deployment and its cluster-admin level prereqs (operate-firs…
374138c 
…t#37)

* ✨ add prow deployment and its cluster-admin level prereqs

Signed-off-by: Christoph Görn <goern@redhat.com>

* incorporate comments from @tumido

Signed-off-by: Christoph Görn <goern@redhat.com>
harshad16 pushed a commit to harshad16/argocd-apps that referenced this pull request Feb 12, 2021
@goern @harshad16
add prow deployment and its cluster-admin level prereqs (operate-firs…
86637e3 
…t#37)

* ✨ add prow deployment and its cluster-admin level prereqs

Signed-off-by: Christoph Görn <goern@redhat.com>

* incorporate comments from @tumido

Signed-off-by: Christoph Görn <goern@redhat.com>
harshad16 pushed a commit to harshad16/argocd-apps that referenced this pull request May 24, 2021
@goern @harshad16
add prow deployment and its cluster-admin level prereqs (operate-firs…
626ad2b 
…t#37)

* ✨ add prow deployment and its cluster-admin level prereqs

Signed-off-by: Christoph Görn <goern@redhat.com>

* incorporate comments from @tumido

Signed-off-by: Christoph Görn <goern@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tumido tumido tumido approved these changes

@harshad16 harshad16 harshad16 left review comments

@HumairAK HumairAK HumairAK approved these changes

@hemajv hemajv Awaiting requested review from hemajv

@4n4nd 4n4nd Awaiting requested review from 4n4nd

@anishasthana anishasthana Awaiting requested review from anishasthana

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Master Board
  
January 2021
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@goern @tumido @4n4nd @sesheta @HumairAK @harshad16