Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

opf-ci-prow component is deployed on moc cluster only #41

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

harshad16
Copy link
Member

opf-ci-prow component is deployed on moc cluster only
Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related-to: #34

As opf-ci-prow is just part of moc cluster, adding it to the patchesStrategicMerge causes issues:

rpc error: code = Unknown desc = `kustomize build /tmp/https:__github.com_operate-first_argocd-apps/overlays/moc --enable_alpha_plugins` failed exit status 1: Error: accumulating resources: accumulateFile "accumulating resources from 'operate-first': '/tmp/https:__github.com_operate-first_argocd-apps/overlays/moc/operate-first' must resolve to a file", accumulateDirector: "recursed accumulation of path '/tmp/https:__github.com_operate-first_argocd-apps/overlays/moc/operate-first': no matches for OriginalId argoproj.io_v1alpha1_Application|~X|ci-prow-cluster-admin; no matches for CurrentId argoproj.io_v1alpha1_Application|~X|ci-prow-cluster-admin; failed to find unique target for patch argoproj.io_v1alpha1_Application|ci-prow-cluster-admin"

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2021
@harshad16 harshad16 added bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2021
@goern
Copy link
Member

goern commented Jan 20, 2021

thanks for fixing this!

/approve
/kind bug

@sesheta sesheta added the kind/bug Categorizes issue or PR as related to a bug. label Jan 20, 2021
@goern
Copy link
Member

goern commented Jan 20, 2021

/assign @HumairAK

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@HumairAK
Copy link
Member

@harshad16 @goern can you use the github approve instead of /approve

@sesheta
Copy link
Member

sesheta commented Jan 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit 6048caf into operate-first:main Jan 20, 2021
harshad16 added a commit to harshad16/argocd-apps that referenced this pull request Jan 31, 2021
…t#41)

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
harshad16 added a commit to harshad16/argocd-apps that referenced this pull request Feb 12, 2021
…t#41)

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
harshad16 added a commit to harshad16/argocd-apps that referenced this pull request May 24, 2021
…t#41)

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@harshad16 harshad16 deleted the fix-files branch May 24, 2021 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants