Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

feat: Add Mailing list analysis toolkit #48

Merged
merged 1 commit into from
Feb 16, 2021
Merged

feat: Add Mailing list analysis toolkit #48

merged 1 commit into from
Feb 16, 2021

Conversation

tumido
Copy link
Member

@tumido tumido commented Jan 22, 2021

@tumido
feat: Add Mailing list analysis toolkit
ff999b8 
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2021
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2021
@tumido
Copy link
Member Author

tumido commented Jan 22, 2021

/hold This app wouldn't deploy successfully now, we need some changes in the content repo

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2021
@tumido tumido mentioned this pull request Jan 22, 2021
Open
5 tasks
@tumido
Copy link
Member Author

tumido commented Feb 11, 2021

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2021
@tumido tumido changed the title wip: feat: Add Mailing list analysis toolkit feat: Add Mailing list analysis toolkit Feb 11, 2021
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2021
@tumido tumido mentioned this pull request Feb 11, 2021
Merged
@martinpovolny
Copy link
Member

/approve

@tumido
Copy link
Member Author

tumido commented Feb 11, 2021

ready to be reviewed and merged

4n4nd
4n4nd reviewed Feb 11, 2021
View reviewed changes
Copy link

@4n4nd 4n4nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2021
@tumido
Copy link
Member Author

tumido commented Feb 11, 2021

please merge operate-first/continuous-deployment#106 first
/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2021
@4n4nd
Copy link

4n4nd commented Feb 11, 2021

please merge operate-first/continuous-deployment#106 first

mrged /unhold

@4n4nd
Copy link

4n4nd commented Feb 11, 2021

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2021
@HumairAK
Copy link
Member

this is only updating the base, did you mean to add it to an environment? (probably moc?)

@tumido
Copy link
Member Author

tumido commented Feb 12, 2021

@HumairAK The base should be pulled in to the overlay. The manifest is rendered properly on:

$ kustomize build overlays/moc/data-science | grep "^  name:"
  name: black-flake
  name: mailing-list-analysis-toolkit

looks fine to me

@HumairAK
Copy link
Member

/approve

@sesheta
Copy link
Member

sesheta commented Feb 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, martinpovolny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021
@sesheta sesheta merged commit 5ce6070 into operate-first:main Feb 16, 2021
harshad16 pushed a commit to harshad16/argocd-apps that referenced this pull request May 24, 2021
@tumido @harshad16
feat: Add Mailing list analysis toolkit (operate-first#48)
2670f59 
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@4n4nd 4n4nd 4n4nd left review comments

@anishasthana anishasthana Awaiting requested review from anishasthana

@martinpovolny martinpovolny Awaiting requested review from martinpovolny

@HumairAK HumairAK Awaiting requested review from HumairAK

Assignees

@4n4nd 4n4nd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tumido @martinpovolny @4n4nd @HumairAK @sesheta