-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add script for yaml validation with kubeval #55
Conversation
I was looking at https://github.com/mimotej/schema-store/tree/add-json-schemas-crds; you'll want to generate the |
7237fc3
to
6516c6b
Compare
@larsks Good idea didn't think about that 👍. The question that only comes to my mind about this is: Should we keep both non-strict and strict schemas in this repository? Because I feel we wouldn't have currently any use for weaker schemas which let slip more error through the checks... I have updated both script and schema-store repository PR to contain only strict variant of schemas. |
I don't see much use for the relaxed schemas in this context, and we can always add them in the future if we decide we have a use case that requires them. Having the strict schemas only right now seems fine. |
/hold |
As a fan of having to wait less time for ci .... any particular reason why we don't just make this part of the |
@HumairAK I don't feel like it is gonna take much longer to run it. |
Signed-off-by: Michal Drla <mdrla@redhat.com>
6516c6b
to
146504b
Compare
/Unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK, larsks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michal Drla mdrla@redhat.com
Related Issues and Dependencies
…
This introduces a breaking change
This Pull Request implements
This PR adds script which can be used in CI to validate YAML manifests using kubeval.
part of: https://github.com/operate-first/SRE/issues/107
Description