Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible using the same default port that is used for Go and Helm #23

Open
camilamacedo86 opened this issue Dec 17, 2020 · 6 comments
Open
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@camilamacedo86
Copy link

Feature Request

Describe the problem you need a feature to resolve.

Add the probes for Ansible as the new flag --health-probe-bind-address was added in operator-framework/operator-sdk#4326.

To keep the backwards compatibility only Ansible is using the port 6789. However, go and helm uses :8081.

So, I am as maintainer and SDK user would like to see ansible configured by default using the port :8081 in order to be easier we give support and keep it maintained as for the users since is not required remember and memorize that each type of language is using a diff port by default

Describe the solution you'd like.

Replace the port 6789 for :8081 .

/language ansible

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@camilamacedo86
Copy link
Author

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 17, 2021
@camilamacedo86
Copy link
Author

camilamacedo86 commented Mar 17, 2021

Hi @estroz @jmrodri, @fabianvf,

Users can choose their ports as they wish. So, should we really consider it a breaking cange that can only be addressed for 2.0? Could we not address this one by changing the default port and adding the steps in the migration guide for those who would like to use the previous default one?

See that we are not removing the flag and or commands only changing the default value in the case.

Advantage: Less deviation, easier to keep maintained and supported, fewer customizations required on top to address the idea kubernetes-sigs/kubebuilder#2015, same reasons/motivations described in A few bad side effect regarding Helm/Ansible starts to deviate from Golang are: in the issue operator-framework/operator-sdk#4542

@jmrodri
Copy link
Member

jmrodri commented Mar 29, 2021

Hi @estroz @jmrodri, @fabianvf,

Users can choose their ports as they wish. So, should we really consider it a breaking cange that can only be addressed for 2.0? Could we not address this one by changing the default port and adding the steps in the migration guide for those who would like to use the previous default one?

See that we are not removing the flag and or commands only changing the default value in the case.

Advantage: Less deviation, easier to keep maintained and supported, fewer customizations required on top to address the idea kubernetes-sigs/kubebuilder#2015, same reasons/motivations described in A few bad side effect regarding Helm/Ansible starts to deviate from Golang are: in the issue operator-framework/operator-sdk#4542

I really think changing the default port is a breaking change. Because if I do the same thing I did before my ports will be different. And I don't see a huge benefit to having the ports being the same.

@camilamacedo86
Copy link
Author

That is fine. I agree that is not a huge benefit too. Just some nit that I'd like to know if you could address before 2.0. Thank you for your time.

@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2023

@camilamacedo86: The label(s) language/ansible cannot be applied, because the repository doesn't have them.

In response to this:

Feature Request

Describe the problem you need a feature to resolve.

Add the probes for Ansible as the new flag --health-probe-bind-address was added in operator-framework/operator-sdk#4326.

To keep the backwards compatibility only Ansible is using the port 6789. However, go and helm uses :8081.

So, I am as maintainer and SDK user would like to see ansible configured by default using the port :8081 in order to be easier we give support and keep it maintained as for the users since is not required remember and memorize that each type of language is using a diff port by default

Describe the solution you'd like.

Replace the port 6789 for :8081 .

/language ansible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@everettraven everettraven transferred this issue from operator-framework/operator-sdk Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants