Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Ansible-based operator, remove the deprecated ping endpoint #24

Open
camilamacedo86 opened this issue Dec 17, 2020 · 3 comments
Open
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@camilamacedo86
Copy link

Feature Request

Describe the problem you need a feature to resolve.

The ping endpoint was deprecated in https://github.com/operator-framework/operator-sdk/pull/4326/files and requires to be removed for 2.0 release.

Describe the solution you'd like.

Remove the following code in internal/cmd/ansible-operator/run/cmd.go:

// todo: remove when a upper version be bumped
err = mgr.AddHealthzCheck("ping", healthz.Ping)
if err != nil {
log.Error(err, "Failed to add Healthz check.")
}

/language ansible

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@camilamacedo86
Copy link
Author

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 17, 2021
@everettraven everettraven transferred this issue from operator-framework/operator-sdk Oct 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2023

@camilamacedo86: The label(s) language/ansible cannot be applied, because the repository doesn't have them.

In response to this:

Feature Request

Describe the problem you need a feature to resolve.

The ping endpoint was deprecated in https://github.com/operator-framework/operator-sdk/pull/4326/files and requires to be removed for 2.0 release.

Describe the solution you'd like.

Remove the following code in internal/cmd/ansible-operator/run/cmd.go:

// todo: remove when a upper version be bumped
err = mgr.AddHealthzCheck("ping", healthz.Ping)
if err != nil {
log.Error(err, "Failed to add Healthz check.")
}

/language ansible

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants