Switch tools management to bingo #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
rashmigottipati
requested review from
oceanc80 and
grokspawn
and removed request for
jberkhahn and
varshaprasad96
grokspawn
reviewed
Feb 22, 2024
grokspawn
reviewed
Feb 22, 2024
everettraven
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Looks good. Could probably remove https://github.com/operator-framework/ansible-operator-plugins/pull/59/files#diff-2d2809b5329aefe0d12b6ec9a166d429b1089b1b7f8577e7cce27846abd53cbcR29-R34 but IMO shouldn't block this.
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
|
@everettraven the link you referenced in your comment points to the entire diff, were you referring to anything specific? I am assuming you're referring to removing Let me know if I'm missing anything else. |
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
everettraven
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the files in .bingo are auto-generated