alm-example validation #115
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gallettilance The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -83,7 +83,7 @@ test: test-unit ## Run the tests | |||
|
|
|||
| TEST_PKGS:=$(shell go list ./...) | |||
| test-unit: ## Run the unit tests | |||
| $(Q)go test -count=1 -short ${TEST_PKGS} | |||
There was a problem hiding this comment.
Any reason we need to add -v? Failing tests always have their details shown, so -v can sometimes make it hard to find the failing test if the entire test suite's details (even for passing tests) are always present.
openshift-ci
bot
added
the
needs-rebase
|
@gallettilance: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -83,7 +83,7 @@ test: test-unit ## Run the tests | |||
|
|
|||
| TEST_PKGS:=$(shell go list ./...) | |||
| test-unit: ## Run the unit tests | |||
| $(Q)go test -count=1 -short ${TEST_PKGS} | |||
| $(Q)go test -count=1 -short ${TEST_PKGS} -v | |||
There was a problem hiding this comment.
ihmo only revert this one, rebase and all shows fine for me.
Really nice contribution.
|
Closes in favor of: #207 |
No description provided.