Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating dependencies #284

Merged
merged 1 commit into from
Jun 26, 2023
Merged

updating dependencies #284

merged 1 commit into from
Jun 26, 2023

Conversation

acornett21
Copy link
Contributor

varshaprasad96
varshaprasad96 requested changes Jun 26, 2023
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acornett21 Thanks for the PR! Can you run make generate to update the manifests. Running make verify target locally would be helpful in verifying if everything is updated.

@acornett21
updating dependencies
164958c 
Signed-off-by: Adam D. Cornett <adc@redhat.com>
@acornett21
Copy link
Contributor Author

@varshaprasad96 I re-ran the above cmds, my IDE was formatting comments in zz_defs since the comments aren't formatted properly. I have reverted this, should be good to go now.

varshaprasad96
varshaprasad96 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@grokspawn
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, grokspawn, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit aa3e498 into operator-framework:master Jun 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@benluddy benluddy Awaiting requested review from benluddy

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@varshaprasad96 varshaprasad96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acornett21 @grokspawn @stevekuznetsov @varshaprasad96 @openshift-merge-robot