catalogsource: allow configuring gRPC server to use well-known opm #293
Conversation
stevekuznetsov
force-pushed
the
skuznets/use-payload-opm
branch
from
930a237
to
e75e02f
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
==========================================
- Coverage 42.11% 41.99% -0.13%
==========================================
Files 39 39
Lines 3495 3505 +10
==========================================
Hits 1472 1472
- Misses 1877 1887 +10
Partials 146 146
☔ View full report in Codecov by Sentry. |
stevekuznetsov
force-pushed
the
skuznets/use-payload-opm
branch
from
e75e02f
to
719055f
Compare
As the file-based catalog schemas mature, the couping between `opm` and the catalog data is effectively removed. We can take advantage of this new property in the system to not require that a server binary exist in the catalog index image, and remove many of the pain-points that come from using the embedded server binary. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/use-payload-opm
branch
from
719055f
to
a7cd18c
Compare
| // ConfigDir is the directory storing the file-based catalog contents. | ||
| ConfigDir string `json:"configDir,omitempty "` |
There was a problem hiding this comment.
This Config terminology comes from the original Declarative Configuration name we gave to this stuff, which was later renamed to File-based catalogs.
Should we call this CatalogDir?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit 039d150
into
operator-framework:master
As the file-based catalog schemas mature, the couping between
opmand the catalog data is effectively removed. We can take advantage of this new property in the system to not require that a server binary exist in the catalog index image, and remove many of the pain-points that come from using the embedded server binary.part of operator-framework/operator-lifecycle-manager#3019
/assign @joelanford