add current profile annotations to CVO manifests #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold I thought it would be better for operator-framework/operator-lifecycle-manager#1832 but I can do it without this PR. |
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
needs-rebase
|
not required finally. |
openshift-ci-robot
removed
the
needs-rebase
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
This is matches openshift/enhancements#510 and doesn't change existing behavior
|
This isn't the right place to be adding non-operator-framework annotations. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Actually this should probably be closed. I suggest making this PR to the downstream OLM repo (when it exists). |
|
Yes, can you PTAL at operator-framework/operator-lifecycle-manager#1897 ? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is matches openshift/enhancements#510 and doesn't change existing behavior