Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: support env var for catalog image #108

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Jul 5, 2023

Add support to override the test catalog image using an environment variable to avoid it being hard-coded.

test/e2e/unpack_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #108 (9250da5) into main (b996f69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   78.11%   78.11%           
=======================================
  Files           1        1           
  Lines         265      265           
=======================================
  Hits          207      207           
  Misses         37       37           
  Partials       21       21           

Add support to override the test catalog image using an environment
variable to avoid it being hard-coded.

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@joelanford joelanford merged commit c691c3e into operator-framework:main Jul 5, 2023
8 checks passed
@ncdc ncdc deleted the env-var-for-e2e-image branch July 6, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants