Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Update openshift-nfd-operator to latest changes #3402

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

ArangoGutierrez
Copy link
Contributor

@J0zi @mvalarh
This PR is needed to sync up this community operator with recent changes to the operator code base.
We removed the check for readiness probe, and users trying to install the operator from OperatorHub community operator edition, are hitting an error bc the container that get's pulled is from the updated version of the operator on the Downstream https://github.com/openshift/cluster-nfd-operator , without this change NFD community edition will be broken for future users .
this is why this is not a simple cosmetic change to an existing release.

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Submit operators to both upstream-community-operators and community-operators at once
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@openshift-ci-robot openshift-ci-robot added the openshift-operator An Operator targeting OpenShift / OKD label Mar 23, 2021
@openshift-ci-robot
Copy link
Collaborator

Hi @ArangoGutierrez. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2021
@github-actions
Copy link
Contributor

/hold

Only minor (cosmetic) changes to already published operator version(s) are allowed.
Consider bumping your operator version. In exceptional cases, it could be overridden by setting allow/serious-changes-to-existing label

More info about allowed changes can be found in [documetnation](https://operator-framework.github.io/community-operators/troubleshooting/#minor-changes).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
@J0zi J0zi added the allow/serious-changes-to-existing Allow bigger changes to an existing CSV label Mar 24, 2021
@J0zi
Copy link
Collaborator

J0zi commented Mar 24, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@J0zi J0zi marked this pull request as draft March 24, 2021 08:43
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2021
@J0zi J0zi marked this pull request as ready for review March 24, 2021 08:43
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2021
@github-actions github-actions bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2021
@mvalarh mvalarh closed this Mar 24, 2021
@mvalarh mvalarh reopened this Mar 24, 2021
@github-actions github-actions bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. allow/operator-recreate User allows to recreate operator and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2021
@mvalarh
Copy link
Collaborator

mvalarh commented Mar 24, 2021

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@mvalarh
Copy link
Collaborator

mvalarh commented Mar 24, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@mvalarh mvalarh removed their assignment Mar 24, 2021
@J0zi
Copy link
Collaborator

J0zi commented Mar 24, 2021

/test all

@ArangoGutierrez
Copy link
Contributor Author

yay all green!!! @J0zi !!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
allow/operator-recreate User allows to recreate operator allow/serious-changes-to-existing Allow bigger changes to an existing CSV ok-to-test Indicates a non-member PR verified by an org member that is safe to test. openshift-operator An Operator targeting OpenShift / OKD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants