Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

community-operators [N] special-resource-operator (0.0.1) #3592

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

dagrayvid
Copy link
Contributor

Please allow operator-version-overwrite for this PR.

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • [] Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Submit operators to both upstream-community-operators and community-operators at once
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • [x One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

@openshift-ci-robot
Copy link
Collaborator

Hi @dagrayvid. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2021
@github-actions github-actions bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2021
@github-actions
Copy link
Contributor

/hold

File community-operators/special-resource-operator/ci.yaml is missing or not valid. More details in failed test Operator CI / operator-ci logs. Documentation how to setup valid ci.yaml file can be found at https://operator-framework.github.io/community-operators/operator-ci-yaml."

Note: Only single file modification on ci.yaml is allowed. Please make separate PR to apply ci.yaml file updates and get it merged before current PR.

Please add comment with /hold cancel when ready.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2021
@github-actions
Copy link
Contributor

/hold

File community-operators/special-resource-operator/ci.yaml is missing or not valid. More details in failed test Operator CI / operator-ci logs. Documentation how to setup valid ci.yaml file can be found at https://operator-framework.github.io/community-operators/operator-ci-yaml."

Note: Only single file modification on ci.yaml is allowed. Please make separate PR to apply ci.yaml file updates and get it merged before current PR.

Please add comment with /hold cancel when ready.

@github-actions
Copy link
Contributor

/hold

Only single file modification on ci.yaml is allowed. Please make separate PR to apply ci.yaml file updates and get it merged before current PR.

Please add comment with /hold cancel when ready.

@dagrayvid
Copy link
Contributor Author

First creating a PR to add reviewers...
#3593

@mvalarh mvalarh marked this pull request as draft April 16, 2021 06:16
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2021
@mvalarh mvalarh marked this pull request as ready for review April 16, 2021 06:17
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2021
@mvalarh mvalarh removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2021
@mvalarh mvalarh added this to To do in Community Operator Submissions via automation Apr 16, 2021
@github-actions github-actions bot changed the title Updating SRO CSV for recent changes to operator. Fix NFD dependency community-operators [N] special-resource-operator (0.0.1) Apr 16, 2021
@github-actions github-actions bot added the new-operator Indicates that this is new operator label Apr 16, 2021
@github-actions
Copy link
Contributor

/hold

Only minor (cosmetic) changes to already published operator version(s) are allowed. Consider bumping your operator version. In exceptional cases, it could be overridden by setting allow/serious-changes-to-existing label set by maintainers and then confirmed action by running command /hold cancel.

More info about allowed changes can be found in documetnation.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2021
@mvalarh mvalarh added the allow/serious-changes-to-existing Allow bigger changes to an existing CSV label Apr 16, 2021
@mvalarh mvalarh marked this pull request as draft April 16, 2021 06:18
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2021
@mvalarh mvalarh marked this pull request as ready for review April 16, 2021 06:18
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2021
@mvalarh mvalarh removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2021
@github-actions github-actions bot added allow/operator-version-overwrite User allows to overwrite operator version ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 16, 2021
@mvalarh
Copy link
Collaborator

mvalarh commented Apr 16, 2021

@dagrayvid Please rebase to current master. So you are not changeing ci.yaml in current PR. Thanks

@mvalarh mvalarh added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2021
…RD version

Signed-off-by: David Gray <dagray@redhat.com>
@dagrayvid
Copy link
Contributor Author

@mvalarh @J0zi This operator has a dependency on Node Feature Discovery. I think I remember from last time I made a PR that the deployment CI tests won't work because they use a custom catalogsource without the dependency available for OLM to install? Do we need to skip this test?

@mvalarh
Copy link
Collaborator

mvalarh commented Apr 16, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2021
@mvalarh mvalarh merged commit c271c6c into operator-framework:master Apr 16, 2021
Community Operator Submissions automation moved this from To do to Done Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
allow/operator-version-overwrite User allows to overwrite operator version allow/serious-changes-to-existing Allow bigger changes to an existing CSV new-operator Indicates that this is new operator ok-to-test Indicates a non-member PR verified by an org member that is safe to test. openshift-operator An Operator targeting OpenShift / OKD
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants