Remove EntitySource #108
Merged
Remove EntitySource #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 61.90% 65.45% +3.54%
==========================================
Files 16 11 -5
Lines 567 495 -72
==========================================
- Hits 351 324 -27
+ Misses 198 152 -46
- Partials 18 19 +1
|
|
Is there some background on this change? |
perdasilva
force-pushed
the
rewrite/entitysrc-per
branch
from
a585358
to
32471fb
Compare
|
Sorry @ncdc - I started this just before I left for holidays. Yeah, the idea was to take Varsha's PR, rebase, fix and put it back here. I'll fill out the description and tie it to a ticket. |
perdasilva
force-pushed
the
rewrite/entitysrc-per
branch
11 times, most recently
from
e3c8255
to
beb7312
Compare
m1kola
reviewed
Aug 10, 2023
cmd/sudoku/sudoku.go
Outdated
| // adapted from: https://github.com/go-air/gini/blob/871d828a26852598db2b88f436549634ba9533ff/sudoku_test.go#L10 | ||
| variables := make(map[deppy.Identifier]*input.SimpleVariable, 0) | ||
| inorder := make([]deppy.Variable, 0) | ||
| rand.Seed(time.Now().UnixNano()) |
There was a problem hiding this comment.
We are not on Go 1.20 yet in Deppy:
Line 3 in d928511
There was a problem hiding this comment.
I just merged the Go 1.20 bump. Need to rebase here now, it looks like.
|
Requires another rebase... |
openshift-merge-robot
added
the
needs-rebase
Removes Entity and EntitySource. The solver takes in the Variable Source directly. The constraints, filters, sort or any transformation should be performed on variables before providing it to solver. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
rewrite/entitysrc-per
branch
from
beb7312
to
54375ee
Compare
openshift-merge-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #95 by rebasing it and fixing merge conflicts. The intent of this PR is to remove the concepts of EntitySource and Entity from Deppy. The
VariableSourceinterface can be implemented with access to specific backend clients (e.g. registry, kube client, etc.) in order to provide theirVariables.Closes #97