This repository has been archived by the owner on Jan 25, 2019. It is now read-only.
Reconcile resources #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasbro17
reviewed
Oct 16, 2018
| return err | ||
| } | ||
| helper := resource.NewHelper(expected.Client, expected.Mapping) | ||
| _, err = helper.Create(expected.Namespace, true, expected.Object) |
There was a problem hiding this comment.
This is interesting. I've never come across the cli-runtime or Info before. Quite convenient that the tiller kubeclient can provide that for us.
hasbro17
reviewed
Oct 16, 2018
| // - If the custom resource does not have a release, a new release will be installed | ||
| // - If the custom resource has changes for an existing release, the release will be updated | ||
| // - If the custom resource has no changes for an existing release, the underlying resources will be reconciled. | ||
| func (c installer) ReconcileRelease(r *unstructured.Unstructured) (*unstructured.Unstructured, bool, error) { |
There was a problem hiding this comment.
One more thing. Not that I can see this anywhere but you might want to double check that none of the installer methods are modifying the installer. Otherwise we should use pointer receivers (c *installer). If not then this is fine.
Just pointing it out since its been a while since I've seen non pointer receivers.
There was a problem hiding this comment.
The struct fields are storageBackend, tillerKubeClient and chartDir, none of which should change, so I think non-pointer receivers is what we want.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add several improvements. It: