Skip to content

Commit

Permalink
workflows: don't process all branches (#249)
Browse files Browse the repository at this point in the history
* workflow/deploy: don't process all branches

In the deploy workflow, using a push branch config of ** results in it
trying to gpg init for branches created by dependabot or anyone/anything
else. This is not what we want - we want those covered by pull request
events.

Change the config to only handle pushes to main (and continue to handle
all tags and all PRs).

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

* workflow/ci: don't process all branches

Change the ci config to only handle pushes to main (and continue to handle
all PRs).

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>

---------

Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
  • Loading branch information
ncdc committed Jan 10, 2024
1 parent b1c9f85 commit 73d2b2c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: CI
on:
push:
branches:
- '**'
- 'main'
pull_request:
branches: [ main ]

Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:

- name: Test
run: make test

- name: Test Sanity
run: make test-sanity

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Deploy
on:
push:
branches:
- '**'
- 'main'
tags:
- 'v*'
pull_request:
Expand All @@ -24,7 +24,7 @@ jobs:
run: .ci/gpg/create-keyring.sh
env:
GPG_PASSWORD: ${{ secrets.GPG_PASSWORD }}

- name: Install Go
uses: actions/setup-go@v4
with:
Expand Down

0 comments on commit 73d2b2c

Please sign in to comment.