Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8S 1.25 Update #200

Merged
merged 13 commits into from Oct 14, 2022
Merged

K8S 1.25 Update #200

merged 13 commits into from Oct 14, 2022

Conversation

theishshah
Copy link
Member

@theishshah theishshah commented Oct 14, 2022 •
edited

PR to Bump K8s version to 1.25 and golang to 1.19

Additionally bumped versions for the linter and underlying support packages to be compatible with the latest golang.

everettraven
everettraven approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look good to me.

@everettraven
Copy link
Contributor

So I think the sanity check in the test action is failing because of the testdata not matching up. I think doing a make generate should fix this

@jmrodri
Copy link
Member

jmrodri commented Oct 14, 2022

So I think the sanity check in the test action is failing because of the testdata not matching up. I think doing a make generate should fix this

That's exactly hat it was, but Ish' go was all jacked up. He had to reinstall :)

jmrodri
jmrodri approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3253021032

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.223%
Totals Coverage Status
Change from base Build 3252637299: 0.0%
Covered Lines: 1631
Relevant Lines: 1828
💛 - Coveralls

@jmrodri jmrodri merged commit 6f61067 into operator-framework:main Oct 14, 2022
@jmrodri jmrodri mentioned this pull request Oct 14, 2022
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@everettraven everettraven everettraven approved these changes

@SimonBaeumer SimonBaeumer Awaiting requested review from SimonBaeumer

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@jmrodri jmrodri

Labels
area/deps area/infra area/main-binary area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@theishshah @everettraven @jmrodri @coveralls