Skip manifest changes if item is in exponential backoff #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
reviewed
Aug 2, 2023
| @@ -0,0 +1,61 @@ | |||
| /* | |||
| Copyright 2023. | |||
There was a problem hiding this comment.
Suggested change
| Copyright 2023. | |
| Copyright 2023 The Operator-SDK Authors. |
| crthandler.EventHandler | ||
| } | ||
|
|
||
| // RequeueFilter wraps the EventHandler and skips the event if it was requeued for the given object |
There was a problem hiding this comment.
Suggested change
| // RequeueFilter wraps the EventHandler and skips the event if it was requeued for the given object | |
| // RequeueFilter wraps the EventHandler but skips the event if it was requeued for the given object. |
| } | ||
|
|
||
| func (q *delegatingQueue) Add(item interface{}) { | ||
| if q.RateLimitingInterface.NumRequeues(item) > 0 { |
There was a problem hiding this comment.
The documentation is rather terse on exact semantics of NumRequeues, and what exactly is considered to be a requeue, so this looks scary to me. For example, does it mean errors will never be retried (apart from the periodic multiple-hour resync)?
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pt. 2 in #224
Filter manifest changes when controller has entered exponential backoff. This prevents any further updates from being made after the rollback.