Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump k8s 1.25 and kb versions #103

Merged
merged 2 commits into from Sep 26, 2022
Merged

bump k8s 1.25 and kb versions #103

merged 2 commits into from Sep 26, 2022

Conversation

laxmikantbpandhare
Copy link
Member

bump k8s 1.25 and kb versions

@laxmikantbpandhare laxmikantbpandhare self-assigned this Sep 19, 2022
@laxmikantbpandhare
Copy link
Member Author

will look into errors once I am back.

@jmrodri
Copy link
Member

jmrodri commented Sep 19, 2022

@laxmikantbpandhare do we need to update the actual java portions for 1.25? https://github.com/operator-framework/java-operator-plugins/blob/main/pkg/quarkus/v1alpha/scaffolds/internal/templates/pomxml.go#L53-L62

@jmrodri
Copy link
Member

jmrodri commented Sep 19, 2022

You will also need to update the github action as part of this PR https://github.com/operator-framework/java-operator-plugins/blob/main/.github/workflows/test-unit.yml#L12

That needs to move to go 1.19

jmrodri
jmrodri requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update github action as part of this PR. And I left a question regarding the scaffold pom.

@everettraven
Copy link
Collaborator

It also does not seem like Kubebuilder has been updated to have dependencies on K8s 1.25 as of that commit. I am planning to update this so this PR may need to be held until that is updated

@laxmikantbpandhare laxmikantbpandhare mentioned this pull request Sep 21, 2022
Closed
13 tasks
@laxmikantbpandhare
Copy link
Member Author

@everettraven @jmrodri - Updated all the dependencies according to suggestions. PTAL

everettraven
everettraven approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I would wait to merge until signoff from @jmrodri as well.

jmrodri
jmrodri approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022
@laxmikantbpandhare laxmikantbpandhare merged commit f025408 into operator-framework:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@everettraven everettraven everettraven approved these changes

Assignees

@jmrodri jmrodri

@laxmikantbpandhare laxmikantbpandhare

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laxmikantbpandhare @jmrodri @everettraven