fix: deprecate install webhook (#1616)

operator-framework · Nov 23, 2022 · 5552723 · 5552723
1 parent 77be8f5
commit 5552723
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 5 deletions.
diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java
@@ -66,6 +66,7 @@ public Operator(KubernetesClient kubernetesClient, ConfigurationService configur
   }
 
   /** Adds a shutdown hook that automatically calls {@link #stop()} when the app shuts down. */
+  @Deprecated(forRemoval = true)
   public void installShutdownHook() {
     Runtime.getRuntime().addShutdownHook(new Thread(this::stop));
   }

diff --git a/operator-framework/src/test/java/io/javaoperatorsdk/operator/InformerRelatedBehaviorITS.java b/operator-framework/src/test/java/io/javaoperatorsdk/operator/InformerRelatedBehaviorITS.java
@@ -211,7 +211,6 @@ Operator startOperator(boolean stopOnInformerErrorDuringStartup, boolean addStop
           }
         });
     operator.register(reconciler);
-    operator.installShutdownHook();
     operator.start();
     return operator;
   }

diff --git a/...election/src/main/java/io/javaoperatorsdk/operator/sample/LeaderElectionTestOperator.java b/...election/src/main/java/io/javaoperatorsdk/operator/sample/LeaderElectionTestOperator.java
@@ -27,7 +27,6 @@ public static void main(String[] args) {
         new Operator(client, c -> c.withLeaderElectionConfiguration(leaderElectionConfiguration));
 
     operator.register(new LeaderElectionTestReconciler(identity));
-    operator.installShutdownHook();
     operator.start();
   }
 }
diff --git a/...rs/mysql-schema/src/main/java/io/javaoperatorsdk/operator/sample/MySQLSchemaOperator.java b/...rs/mysql-schema/src/main/java/io/javaoperatorsdk/operator/sample/MySQLSchemaOperator.java
@@ -34,7 +34,6 @@ public static void main(String[] args) throws IOException {
         configOverrider -> configOverrider.replacingNamedDependentResourceConfig(
             SchemaDependentResource.NAME,
             new ResourcePollerConfig(300, MySQLDbConfig.loadFromEnvironmentVars())));
-    operator.installShutdownHook();
     operator.start();
 
     new FtBasic(new TkFork(new FkRegex("/health", "ALL GOOD!")), 8080).start(Exit.NEVER);

diff --git a/...tors/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/TomcatOperator.java b/...tors/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/TomcatOperator.java
@@ -22,7 +22,6 @@ public static void main(String[] args) throws IOException {
     Operator operator = new Operator(client);
     operator.register(new TomcatReconciler());
     operator.register(new WebappReconciler(client));
-    operator.installShutdownHook();
     operator.start();
 
     new FtBasic(new TkFork(new FkRegex("/health", "ALL GOOD.")), 8080).start(Exit.NEVER);

diff --git a/...e-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageOperator.java b/...e-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageOperator.java
@@ -33,7 +33,6 @@ public static void main(String[] args) throws IOException {
     } else {
       operator.register(new WebPageStandaloneDependentsReconciler(client));
     }
-    operator.installShutdownHook();
     operator.start();
 
     new FtBasic(new TkFork(new FkRegex("/health", "ALL GOOD!")), 8080).start(Exit.NEVER);