improve: primary to secondary index edge case for dynamic mapper chan…

…ges (#2246)



Signed-off-by: Attila Mészáros <csviri@gmail.com>

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/DefaultPrimaryToSecondaryIndex.java

@@ -33,9 +33,14 @@ public synchronized void onDelete(R resource) {
     primaryResources.forEach(
         primaryResource -> {
           var secondaryResources = index.get(primaryResource);
-          secondaryResources.remove(ResourceID.fromResource(resource));
-          if (secondaryResources.isEmpty()) {
-            index.remove(primaryResource);
+          // this can be null in just very special cases, like when the secondaryToPrimaryMapper is
+          // changing dynamically. Like if a list of ResourceIDs mapped dynamically extended in the
+          // mapper between the onAddOrUpdate and onDelete is called.
+          if (secondaryResources != null) {
+            secondaryResources.remove(ResourceID.fromResource(resource));
+            if (secondaryResources.isEmpty()) {
+              index.remove(primaryResource);
+            }
           }
         });
   }