Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: runtime info for health probes #1594

Merged
merged 9 commits into from Nov 23, 2022
Merged

feat: runtime info for health probes #1594

merged 9 commits into from Nov 23, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Nov 8, 2022

Expose runtime information mainly about event sources and informers so that can be used to create custom / tailored liveness probes.

@csviri csviri self-assigned this Nov 8, 2022
@csviri csviri marked this pull request as draft November 8, 2022 12:57
@csviri
Copy link
Collaborator Author

csviri commented Nov 8, 2022

closes #1340
closes #1412

@csviri csviri marked this pull request as ready for review November 9, 2022 09:54
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from documentation.

Comment on lines 704 to 705
[RuntimeInfo](https://github.com/java-operator-sdk/java-operator-sdk/blob/main/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/RuntimeInfo.java#L16-L16)
is accessed. You can access mainly health information of event sources. Based on that liveness probes can be registered
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence doesn't work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformulated.

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

15.8% 15.8% Coverage
0.0% 0.0% Duplication

metacosm pushed a commit that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for K8S Probes Handle configuration errors for Operators
2 participants