feat: explicit workflow invocation #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
custom-invocation-workflow
branch
from
6433325
to
883c3ad
Compare
Signed-off-by: Chris Laprun <claprun@redhat.com>
metacosm
approved these changes
Mar 18, 2024
csviri
commented
Mar 18, 2024
docs/documentation/workflows.md
Outdated
|
|
||
| // additional logic before the workflow is executed | ||
|
|
||
| context.managedWorkflowAndDependentResourceContext().reconcileManagedWorkflow(); |
There was a problem hiding this comment.
@metacosm why did you delete sample code from here?
There was a problem hiding this comment.
Because it doesn't add much, imo, and would need to be kept up to date (as are the other samples)…
There was a problem hiding this comment.
will merge this now as it is, when we migrate to docsy, would be nice to revisit the principles for the dox though
csviri
added a commit
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm
pushed a commit
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm
pushed a commit
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
May 17, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
May 17, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
May 21, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.