Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: processor concurrency issue on startup #2328

Merged
merged 2 commits into from
Apr 3, 2024
Merged

fix: processor concurrency issue on startup #2328

merged 2 commits into from
Apr 3, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 3, 2024

This should fix the related issue when on startup theoretically an event can be received when the processor is starting. Considering:

  • On startup event received while EventProcess is not started yet
  • EventProcessor starts and submits all the events (distinguished by resource id) to reconcile
  • But mean while a new event is received for a certain resource that was also getting submitted by the start operation

@csviri csviri changed the title fix: processor concurrency issue startup fix: processor concurrency issue on startup Apr 3, 2024
csviri and others added 2 commits April 3, 2024 12:31
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri merged commit 4458c53 into main Apr 3, 2024
20 checks passed
@csviri csviri deleted the concurrency-issue branch April 3, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconciliation for one Reconciler is sometimes executed in parallel in two different threads
2 participants