Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move getResourceClassResolver to BaseConfigurationService #2451

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

metacosm
Copy link
Collaborator

The class resolving mechanism is only needed in that class right now

Signed-off-by: Chris Laprun claprun@redhat.com

The class resolving mechanism is only needed in that class right now

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm self-assigned this Jun 20, 2024
@metacosm metacosm requested a review from csviri June 20, 2024 09:02
@openshift-ci openshift-ci bot requested a review from adam-sandor June 20, 2024 09:02
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simpler is better :)

@metacosm metacosm merged commit 976a091 into next Jun 20, 2024
20 checks passed
@metacosm metacosm deleted the remove-class-resolver branch June 20, 2024 13:31
metacosm added a commit that referenced this pull request Jul 8, 2024
…2451)

The class resolving mechanism is only needed in that class right now

Signed-off-by: Chris Laprun <claprun@redhat.com>
metacosm added a commit that referenced this pull request Jul 9, 2024
…2451)

The class resolving mechanism is only needed in that class right now

Signed-off-by: Chris Laprun <claprun@redhat.com>
metacosm added a commit that referenced this pull request Jul 12, 2024
…2451)

The class resolving mechanism is only needed in that class right now

Signed-off-by: Chris Laprun <claprun@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants