fix(uninstall): rely on OLM to delete operator resources via CSV deletion #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshaprasad96
force-pushed
the
fix/get-installplan
branch
from
fdc63c0
to
30ee369
Compare
joelanford
reviewed
Nov 5, 2020
joelanford
reviewed
Nov 5, 2020
openshift-ci-robot
added
the
needs-rebase
varshaprasad96
force-pushed
the
fix/get-installplan
branch
from
30ee369
to
e770ac4
Compare
openshift-ci-robot
removed
the
needs-rebase
varshaprasad96
force-pushed
the
fix/get-installplan
branch
from
e770ac4
to
0f2ab2d
Compare
joelanford
reviewed
Nov 9, 2020
varshaprasad96
force-pushed
the
fix/get-installplan
branch
from
0f2ab2d
to
8e8b0a7
Compare
joelanford
reviewed
Nov 10, 2020
|
Based on some discussion with the OLM team, I think we can immediately improve on solving this problem by ignoring the install plan altogether and deleting only the CSV and CRDs. We can lookup the CSV using And then lookup the CRDs from |
varshaprasad96
force-pushed
the
fix/get-installplan
branch
from
8e8b0a7
to
494ed0d
Compare
joelanford
reviewed
Nov 11, 2020
joelanford
changed the title
varshaprasad96
force-pushed
the
fix/get-installplan
branch
from
494ed0d
to
01823b2
Compare
joelanford
reviewed
Nov 11, 2020
When multiple install plans are present for single operator, select the resources of install plan containing the installed CSV while uninstalling the operator.
varshaprasad96
force-pushed
the
fix/get-installplan
branch
from
01823b2
to
6ea2e2c
Compare
joelanford
dismissed
jmrodri’s stale review
These suggestions were incorporated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple install plans are present for single operator,
select the resources of install plan containing the installed CSV
while uninstalling the operator.