Move logging.basicConfig() from api to cli #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
MartinBasti
approved these changes
Mar 12, 2019
|
@awgreene can you specify in the pr description and the commit message why you are making this change? |
awgreene
force-pushed
the
move-basic-logging
branch
from
738ebb0
to
9f90907
Compare
|
@kevinrizza addressed. |
awgreene
force-pushed
the
move-basic-logging
branch
2 times, most recently
from
4649c03
to
d04f08e
Compare
Logging should be set in the cli rather than the api to avoid overwritting logging settings set by the user. Fixes operator-framework#58
awgreene
force-pushed
the
move-basic-logging
branch
from
d04f08e
to
c998d36
Compare
|
/lgmt coverage decrease is just common fluctuation as we moved lines to another file |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging should be set in the cli rather than the api to
avoid overwritting logging settings set by the user.
Fixes #58