Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang & k8s dependencies #167

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Update golang & k8s dependencies #167

merged 4 commits into from
Apr 30, 2024

Conversation

Neo2308
Copy link
Contributor

@Neo2308 Neo2308 commented Apr 26, 2024 •
edited

  • Updated golang version to 1.21
  • Updated golangci-lint to 1.57
  • Updated k8s dependencies to v0.29.2
  • Updated operator-framework/api to v0.23.0
  • Updates leader package test logic to fix a test failure related to the GVK and type meta not being set after performing a GET with a controller-runtime fake client (copied from Bump k8s to 1.29 #163)

Relates to: operator-framework/operator-sdk#6651

@Neo2308
Update golang & k8s dependencies
04950ae 
* Updated golang version to 1.21
* Updated k8s dependencies to v0.29.2
* Updated operator-framework/api to v0.23.0
@Neo2308 Neo2308 requested a review from a team as a code owner April 26, 2024 06:53
@Neo2308 Neo2308 mentioned this pull request Apr 26, 2024
Open
13 tasks
Neo2308 added a commit to Neo2308/ansible-operator-plugins that referenced this pull request Apr 26, 2024
@Neo2308
Update k8s dependencies
04c7c62 
* Updated k8s dependencies to v0.29.3
* Updated operator-framework/operator-registry to v1.39.0
* Updated kubebuilder to v3.14.1
* Updated k8s version in Makefile

TODO:
Update operator-framework/operator-lib after operator-framework/operator-lib#167 is merged
@Neo2308 Neo2308 mentioned this pull request Apr 26, 2024
Open
@Neo2308
Copy test fixes.
7b4a134
@Neo2308
Fix lint issues
808c615 
Update golangci-lint to 1.57
Apply lint fixes
@Neo2308
Fix lint issues
2610400
@Neo2308 Neo2308 mentioned this pull request Apr 26, 2024
Closed
@Neo2308
Copy link
Contributor Author

Neo2308 commented Apr 26, 2024

@everettraven could you review/merge this PR?

everettraven
everettraven approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@everettraven everettraven added this pull request to the merge queue Apr 30, 2024
Merged via the queue into operator-framework:main with commit b394e34 Apr 30, 2024
4 checks passed
@Neo2308 Neo2308 deleted the feature/main/bump-k8s-0.29.2 branch May 3, 2024 08:53
Neo2308 added a commit to Neo2308/ansible-operator-plugins that referenced this pull request May 15, 2024
@Neo2308
Update k8s dependencies
00c3ff2 
* Updated k8s dependencies to v0.29.3
* Updated operator-framework/operator-registry to v1.39.0
* Updated kubebuilder to v3.14.1
* Updated k8s version in Makefile

TODO:
Update operator-framework/operator-lib after operator-framework/operator-lib#167 is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees

@everettraven everettraven

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Neo2308 @everettraven