Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s dependencies and controller-runtime #40

Merged

Conversation

varshaprasad96
Copy link
Member

Description of the change:
Bump k8s dependencirs to v1.19+ and controller-runtime to v0.7.0-alpha.6

Motivation for the change:
k8s 1.19+ is needed to have helper functions for operator conditions
Ref: metav1.Conditions

Bump k8s dependencirs to v0.19+ and controller-runtime to v0.7.0-alpha.6
@coveralls
Copy link

coveralls commented Nov 19, 2020

Pull Request Test Coverage Report for Build 373042909

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.7%) to 74.221%

Files with Coverage Reduction New Missed Lines %
predicate/nogeneration.go 6 66.67%
Totals Coverage Status
Change from base Build 366326250: -1.7%
Covered Lines: 262
Relevant Lines: 353

💛 - Coveralls

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@joelanford
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6700ae5 into operator-framework:main Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants