Add helpers for operator-conditions #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Pull Request Test Coverage Report for Build 373315720
💛 - Coveralls |
This PR adds helpers for operator conditions CR created by OLM for the operator.
varshaprasad96
force-pushed
the
add/conditions-helpers
branch
2 times, most recently
from
c947b33
to
44a126a
Compare
varshaprasad96
force-pushed
the
add/conditions-helpers
branch
from
44a126a
to
f60ce2e
Compare
varshaprasad96
removed
the
do-not-merge/work-in-progress
varshaprasad96
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
varshaprasad96
removed
the
do-not-merge/work-in-progress
jmrodri
approved these changes
Nov 20, 2020
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmrodri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
estroz
reviewed
Nov 20, 2020
estroz
reviewed
Nov 20, 2020
| ErrNoOperatorCondition = fmt.Errorf("operator Condition CRD is nil") | ||
| ) | ||
|
|
||
| // TODO: verify from OLM if this will be the name of the environment variable |
There was a problem hiding this comment.
@awgreene can you confirm? Afaik this is the name discussed in the EP
There was a problem hiding this comment.
This name is fine, if you prefer something else just let me know.
estroz
reviewed
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR adds helpers for the Operator Conditions custom resource introduced by OLM. With the help of this package users can:
Motivation for the change:
Provide support for working with Operator Conditions CRD.