Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fakeclient instead of envtest #44

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Use fakeclient instead of envtest #44

merged 1 commit into from
Dec 4, 2020

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Dec 4, 2020

Description of the change:
Remove the reliance on envtest for testing this library. Switched to using just the controller-runtime fakeclient.

Motivation for the change:
Keep the dependencies to a minimum

@jmrodri jmrodri requested review from varshaprasad96 and removed request for jmccormick2001 and fabianvf December 4, 2020 04:47
@coveralls
Copy link

coveralls commented Dec 4, 2020 •
edited

Pull Request Test Coverage Report for Build 399948066

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.482%
Totals Coverage Status
Change from base Build 399917225: 0.0%
Covered Lines: 320
Relevant Lines: 413
💛 - Coveralls

estroz
estroz approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably ok because these are unit tests and are not testing complex behavior.

/approve
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 931e9a7 into operator-framework:main Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz approved these changes

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmrodri @coveralls @openshift-ci-robot @estroz @openshift-merge-robot