Skip to content

Commit

Permalink
.github/workflows: Avoid specifying the paths-ignore keyword (#2511)
Browse files Browse the repository at this point in the history
Update the CI-related workflows and avoid specifying the paths-ignore
keyword. Because we have configure required status contexts through
branch protection rules, any workflow that is skipped due to path
filtering results in an unknown status, which results in tide stalling
any merge despite a PR matching the merge criteria (e.g. lgtm/approval
label present).

This is a short term fix to the solution: the long term
solution is dynamically filtering out certain file paths as a
pre-requisite job vs. statically filtering using the paths-ignore
filter, while we wait for GitHub to add this as first-class functionality.

Signed-off-by: timflannagan <timflannagan@gmail.com>
  • Loading branch information
timflannagan committed Dec 7, 2021
1 parent 3949ceb commit 285a535
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 14 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: build
on:
pull_request:
paths-ignore:
- '**/*.md'
jobs:
image:
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ on:
branches:
- master
pull_request:
paths-ignore:
- '**/*.md'
jobs:
e2e-tests:
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/run-kind-local.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: run-olm-kind
on:
pull_request:
paths-ignore:
- '**/*.md'
schedule:
- cron: '0 0 * * *' # daily to pick up releases
jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/run-minikube-local.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: run-olm-minikube
on:
pull_request:
paths-ignore:
- '**/*.md'
schedule:
- cron: '0 0 * * *' # daily to pick up releases
jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/sanity.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ on:
branches:
- '**'
pull_request:
paths-ignore:
- '**/*.md'
jobs:
sanity:
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ on:
branches:
- master
pull_request:
paths-ignore:
- '**/*.md'
jobs:
unit:
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ on:
branches:
- master
pull_request:
paths-ignore:
- '**/*.md'
jobs:
verify:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 285a535

Please sign in to comment.