-
Notifications
You must be signed in to change notification settings - Fork 541
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
.github/workflows: Avoid specifying the paths-ignore keyword (#2511)
Update the CI-related workflows and avoid specifying the paths-ignore keyword. Because we have configure required status contexts through branch protection rules, any workflow that is skipped due to path filtering results in an unknown status, which results in tide stalling any merge despite a PR matching the merge criteria (e.g. lgtm/approval label present). This is a short term fix to the solution: the long term solution is dynamically filtering out certain file paths as a pre-requisite job vs. statically filtering using the paths-ignore filter, while we wait for GitHub to add this as first-class functionality. Signed-off-by: timflannagan <timflannagan@gmail.com>
- Loading branch information
1 parent
3949ceb
commit 285a535
Showing
7 changed files
with
0 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
name: build | ||
on: | ||
pull_request: | ||
paths-ignore: | ||
- '**/*.md' | ||
jobs: | ||
image: | ||
runs-on: ubuntu-latest | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,6 @@ on: | |
branches: | ||
- '**' | ||
pull_request: | ||
paths-ignore: | ||
- '**/*.md' | ||
jobs: | ||
sanity: | ||
runs-on: ubuntu-latest | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,6 @@ on: | |
branches: | ||
- master | ||
pull_request: | ||
paths-ignore: | ||
- '**/*.md' | ||
jobs: | ||
unit: | ||
runs-on: ubuntu-latest | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,6 @@ on: | |
branches: | ||
- master | ||
pull_request: | ||
paths-ignore: | ||
- '**/*.md' | ||
jobs: | ||
verify: | ||
runs-on: ubuntu-latest | ||
|