Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop relying on pgrep -q #1011

Merged
merged 1 commit into from Aug 30, 2019

Conversation

skitt
Copy link
Contributor

@skitt skitt commented Aug 27, 2019

Many distributions don't support pgrep -q, which causes build_local.sh
to behave incorrectly. This patch redirects to /dev/null instead.

Signed-off-by: Stephen Kitt skitt@redhat.com

Many distributions don't support pgrep -q, which causes build_local.sh
to behave incorrectly. This patch redirects to /dev/null instead.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2019
@jpeeler
Copy link
Contributor

jpeeler commented Aug 27, 2019

/approve
/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpeeler, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@ecordell
Copy link
Member

/retest

@skitt
Copy link
Contributor Author

skitt commented Aug 30, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 0953728 into operator-framework:master Aug 30, 2019
@skitt skitt deleted the pgrep-no-q branch August 30, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants