Install InstallPlan #102
Merged
Install InstallPlan #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
requested changes
Oct 17, 2017
operators/catalog/operator.go
Outdated
| continue | ||
| } | ||
|
|
||
| case "ClusterServiceVersion-v1": |
There was a problem hiding this comment.
can you use the constants for these from the types.go?
operators/catalog/operator.go
Outdated
| } | ||
|
|
||
| default: | ||
| panic("attempted to install an unknown resource Kind") |
There was a problem hiding this comment.
this will just kill the operator right? we don't want that?
operators/catalog/operator.go
Outdated
| } | ||
|
|
||
| default: | ||
| panic("attempted to install step in a plan with an undefined status") |
ecordell
approved these changes
Oct 17, 2017
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
…allplan Install InstallPlan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.