bug 1771811: make certificate updates live upon update #1151
Conversation
Watcher is a generic (also cross platform) file watching mechanism for receiving file system events in real time. A simple API has been written to watch a list of paths and to run a user defined callback for processing of the events. Using the above, a keystore has been made such that when a target directory containing certificates are updated the contents are made available via a callback. This callback is compatible with passing to an http server tls config, which allows for zero downtime certificate swapping.
|
@jpeeler: This pull request references Bugzilla bug 1771811, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test e2e-aws-console-olm |
|
/retest |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@ecordell: This pull request references Bugzilla bug 1771811, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@jpeeler: All pull requests linked via external trackers have merged. Bugzilla bug 1771811 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@jpeeler: new pull request created: #1165 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
This modifies the metrics https configuration to dynamically update certificates if the backing secrets are updated.
Motivation for the change:
Certificate rotation is a necessary feature given that certificates eventually expire.
Reviewer Checklist
/docs