Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1791887: chore(ci): add dockerfile as a base for building in CI #1212

Merged
merged 2 commits into from Jan 3, 2020

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Jan 2, 2020

Description of the change:
Adds (really, updates an old) dockerfile to be used as a base for CI so that other dependencies can be added.

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2020
@ecordell
Copy link
Member Author

ecordell commented Jan 2, 2020

/retest

@exdx
Copy link
Member

exdx commented Jan 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2020
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2020
@exdx
Copy link
Member

exdx commented Jan 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@exdx
Copy link
Member

exdx commented Jan 3, 2020

/test e2e-aws-olm

@ecordell
Copy link
Member Author

ecordell commented Jan 3, 2020

This change doesn't (yet) affect e2e-olm-aws, merging since the cluster setup failed

@ecordell ecordell merged commit aba52e8 into operator-framework:master Jan 3, 2020
@openshift-ci-robot
Copy link
Collaborator

@ecordell: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm d8eab58 link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Bowenislandsong Bowenislandsong changed the title chore(ci): add dockerfile as a base for building in CI Bug 1791887: chore(ci): add dockerfile as a base for building in CI Jan 17, 2020
@openshift-ci-robot
Copy link
Collaborator

@ecordell: Bugzilla bug 1791887 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1791887: chore(ci): add dockerfile as a base for building in CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bowenislandsong
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: All pull requests linked via external trackers have merged. Bugzilla bug 1791887 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants