New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.1] Bug 1791850: Removing license year #1242
[release-4.1] Bug 1791850: Removing license year #1242
Conversation
@Bowenislandsong: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Bowenislandsong: This pull request references Bugzilla bug 1791852, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Bowenislandsong: This pull request references Bugzilla bug 1791850, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this commit removes the license year from code base and unblocks PRs that fails on the verify test.
c330bfa
to
eeb792a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bowenislandsong, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This does not look like a must have 4.1 fix. |
It is a must have and it is blocking all backports to 4.1 |
We currently see no reason to do a 4.1.z release just to pick up this PR. If we have a critical fix for 4.1 in the future, we can consider including this PR at that point in time. |
#1312 needs to merge in 4.1 and is currently blocked on CI due to this PR. |
This licensing PR currently blocks this CVE run-level PR: #1312 |
(sorry, this has to wait until tomorrow anyway) |
/retest Please review the full test history for this PR and help us cut down flakes. |
@Bowenislandsong: An error was encountered searching for external tracker bugs for bug 1791850 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
this commit removes the license year from code base and unblocks PRs that fails on the verify test.
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs