Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.1] Bug 1791850: Removing license year #1242

Conversation

Bowenislandsong
Copy link
Member

this commit removes the license year from code base and unblocks PRs that fails on the verify test.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Removing license year

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2020
@Bowenislandsong Bowenislandsong changed the title Removing license year Bug 1791852: [release-4.1] Removing license year Jan 21, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 21, 2020
@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: This pull request references Bugzilla bug 1791852, which is invalid:

  • expected the bug to target the "4.1.z" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1791852: [release-4.1] Removing license year

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bowenislandsong Bowenislandsong changed the title Bug 1791852: [release-4.1] Removing license year [release-4.1] Bug 1791850: Removing license year Jan 21, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 21, 2020
@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: This pull request references Bugzilla bug 1791850, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.1] Bug 1791850: Removing license year

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 21, 2020
this commit removes the license year from code base and unblocks PRs that fails on the verify test.
@ecordell
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bowenislandsong, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@njhale
Copy link
Member

njhale commented Jan 23, 2020

/retest

@ashcrow ashcrow added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 5, 2020
@ashcrow
Copy link

ashcrow commented Feb 5, 2020

This does not look like a must have 4.1 fix.

@Bowenislandsong
Copy link
Member Author

This does not look like a must have 4.1 fix.

It is a must have and it is blocking all backports to 4.1

@bparees
Copy link

bparees commented Feb 19, 2020

We currently see no reason to do a 4.1.z release just to pick up this PR. If we have a critical fix for 4.1 in the future, we can consider including this PR at that point in time.

@bparees bparees added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Feb 19, 2020
@ecordell
Copy link
Member

ecordell commented Mar 4, 2020

#1312 needs to merge in 4.1 and is currently blocked on CI due to this PR.

@dinhxuanvu
Copy link
Member

This licensing PR currently blocks this CVE run-level PR: #1312

@sdodson
Copy link

sdodson commented Mar 10, 2020

This licensing PR currently blocks this CVE run-level PR: #1312

I'll pull this in but I think the proper way to have addressed this is to simply have included this commit in #1312

@sdodson sdodson added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Mar 10, 2020
@sdodson sdodson added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 10, 2020
@sdodson
Copy link

sdodson commented Mar 10, 2020

(sorry, this has to wait until tomorrow anyway)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7137aa9 into operator-framework:release-4.1 Mar 11, 2020
@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: An error was encountered searching for external tracker bugs for bug 1791850 on the Bugzilla server at https://bugzilla.redhat.com:

could not parse external identifier "https://github.com/operator-framework/operator-lifecycle-manager/pull/1236/files" as pull: invalid pull identifier with 8 parts: "https://github.com/operator-framework/operator-lifecycle-manager/pull/1236/files"
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.1] Bug 1791850: Removing license year

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale
Copy link
Member

njhale commented Mar 24, 2020

/bugzilla refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants