Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overly broad .gitignore pattern that was excluding a vendored pac… #1250

Merged
merged 1 commit into from Jan 29, 2020
Merged

Fix overly broad .gitignore pattern that was excluding a vendored pac… #1250

merged 1 commit into from Jan 29, 2020

Conversation

benluddy
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2020
@dinhxuanvu
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@exdx
Copy link
Member

exdx commented Jan 24, 2020 •
edited

This enables make run-local which is currently hiccuping on a missing helm pkg incorrectly ignored via the .gitignore pattern

@exdx
Copy link
Member

exdx commented Jan 27, 2020

/retest

2 similar comments
@benluddy
Copy link
Contributor Author

/retest

@benluddy
Copy link
Contributor Author

/retest

@benluddy benluddy force-pushed the fix-release-gitignore-pattern branch from e705e6b to f0ecf53 Compare January 27, 2020 15:46
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2020
@benluddy
Copy link
Contributor Author

/retest

1 similar comment
@benluddy
Copy link
Contributor Author

/retest

@exdx
Copy link
Member

exdx commented Jan 28, 2020

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@benluddy benluddy changed the title Fix overly broad .gitignore pattern that was excluding a vendored pac… Bug 1795653: Fix overly broad .gitignore pattern that was excluding a vendored pac… Jan 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2020
@openshift-ci-robot
Copy link
Collaborator

@benluddy: This pull request references Bugzilla bug 1795653, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1795653: Fix overly broad .gitignore pattern that was excluding a vendored pac…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@benluddy: This pull request references Bugzilla bug 1795653, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy benluddy changed the title Bug 1795653: Fix overly broad .gitignore pattern that was excluding a vendored pac… Fix overly broad .gitignore pattern that was excluding a vendored pac… Jan 28, 2020
@openshift-ci-robot
Copy link
Collaborator

@benluddy: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix overly broad .gitignore pattern that was excluding a vendored pac…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2020
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, dinhxuanvu, ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@benluddy
Copy link
Contributor Author

/retest

3 similar comments
@benluddy
Copy link
Contributor Author

/retest

@benluddy
Copy link
Contributor Author

/retest

@benluddy
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit f586aaf into operator-framework:master Jan 29, 2020
@benluddy benluddy deleted the fix-release-gitignore-pattern branch January 29, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeeler jpeeler Awaiting requested review from jpeeler

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

@dinhxuanvu dinhxuanvu

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@benluddy @dinhxuanvu @exdx @openshift-ci-robot @ecordell @openshift-merge-robot