Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1797675: Refactoring rh-operator test directory #1274

Merged

Conversation

Bowenislandsong
Copy link
Member

The rh-operator tests including metric cardinality is not in scope of
OLM e2e tests. This commit moves those tests out of e2e directory
and avoids those tests from becoming e2e tests targets. The commit
also reverts a change in the makefile that avoided them as test
targets from previous directory layout. The rh-operator tests are
removable from OLM repo and should require least amount of effort
in removing them as makefile targets.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

The rh-operator tests including metric cardinality is not in scope of
OLM e2e tests. This commit moves those tests out of e2e directory
and avoids those tests from becoming e2e tests targets. The commit
also reverts a change in the makefile that avoided them as test
targets from previous directory layout. The rh-operator tests are
removable from OLM repo and should require least amount of effort
in removing them as makefile targets.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2020
@Bowenislandsong Bowenislandsong changed the title refactor rh-operator test directory Bug 1797675: bug refactor rh-operator test directory Feb 3, 2020
@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: This pull request references Bugzilla bug 1797675, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1797675: bug refactor rh-operator test directory

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 3, 2020
@Bowenislandsong Bowenislandsong changed the title Bug 1797675: bug refactor rh-operator test directory Bug 1797675: Refactoring rh-operator test directory Feb 3, 2020
@Bowenislandsong
Copy link
Member Author

/retest

1 similar comment
@Bowenislandsong
Copy link
Member Author

/retest

@benluddy
Copy link
Contributor

benluddy commented Feb 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, Bowenislandsong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7dc5359 into operator-framework:master Feb 4, 2020
@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: All pull requests linked via external trackers have merged. Bugzilla bug 1797675 has been moved to the MODIFIED state.

In response to this:

Bug 1797675: Refactoring rh-operator test directory

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants