Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update existing robot credentials #1276

Merged
merged 1 commit into from Feb 4, 2020
Merged

fix: update existing robot credentials #1276

merged 1 commit into from Feb 4, 2020

Conversation

exdx
Copy link
Member

@exdx exdx commented Feb 4, 2020 •
edited

Description of the change:
Updates robot credentials that were accidentally deleted.

These credentials will be removed once #1257 lands.

Motivation for the change:
This anticipates and fixes the issue where e2e olm tests will fail on CI due to the fact that the previous credentials were deleted.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2020
dinhxuanvu
dinhxuanvu approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@exdx
Copy link
Member Author

exdx commented Feb 4, 2020

/test unit

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dinhxuanvu, exdx, gallettilance
To complete the pull request process, please assign njhale
You can assign the PR to them by writing /assign @njhale in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@exdx
Copy link
Member Author

exdx commented Feb 4, 2020

/retest

4 similar comments
@exdx
Copy link
Member Author

exdx commented Feb 4, 2020

/retest

@ecordell
Copy link
Member

ecordell commented Feb 4, 2020

/retest

@exdx
Copy link
Member Author

exdx commented Feb 4, 2020

/retest

@exdx
Copy link
Member Author

exdx commented Feb 4, 2020

/retest

@exdx
Copy link
Member Author

exdx commented Feb 4, 2020

/test e2e-gcp-upgrade

@exdx exdx merged commit 8534ecd into operator-framework:master Feb 4, 2020
@exdx exdx deleted the fix/update-robot-creds branch February 4, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@gallettilance gallettilance gallettilance approved these changes

Assignees

@dinhxuanvu dinhxuanvu

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@exdx @openshift-ci-robot @ecordell @dinhxuanvu @gallettilance