Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1805412: Support multiple APIServices on a single deployment #1339

Merged
merged 1 commit into from Mar 16, 2020
Merged

Bug 1805412: Support multiple APIServices on a single deployment #1339

merged 1 commit into from Mar 16, 2020

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Mar 2, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2020
kevinrizza
kevinrizza requested changes Mar 2, 2020
View reviewed changes
Copy link
Member

@kevinrizza kevinrizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment and tests. Otherwise looks good to me.

pkg/controller/operators/olm/apiservices.go Outdated Show resolved Hide resolved
@awgreene awgreene changed the title WIP Bug 1805412 Bug 1805412: Support multiple APIServices on a single deployment Mar 3, 2020
@awgreene
Copy link
Member Author

awgreene commented Mar 3, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@awgreene
Copy link
Member Author

awgreene commented Mar 3, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 3, 2020
@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1805412, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2020
@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1805412, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1805412: Support multiple APIServices on a single deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene awgreene changed the title Bug 1805412: Support multiple APIServices on a single deployment WIP Bug 1805412: Support multiple APIServices on a single deployment Mar 3, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2020
@Bowenislandsong
Copy link
Member

lgtm except for the format and the conflicts. Thanks!

harishsurf
harishsurf reviewed Mar 4, 2020
View reviewed changes
Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. nit: Not sure what the norm is but a single line comment for each of the newly introduced func() for easier code readability ?

pkg/controller/operators/olm/apiservices.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 4, 2020
njhale
njhale reviewed Mar 4, 2020
View reviewed changes
pkg/controller/operators/olm/apiservices.go Outdated Show resolved Hide resolved
pkg/controller/operators/olm/apiservices.go Outdated Show resolved Hide resolved
pkg/controller/operators/olm/apiservices.go Outdated Show resolved Hide resolved
@awgreene awgreene closed this Mar 5, 2020
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 5, 2020
@awgreene
Copy link
Member Author

/retest

error: unable to read image registry.svc.ci.openshift.org/ci-op-0mngk4xd/stable-initial@sha256:595142acf537b1b17b8e340c2de6b73364c79034401d58f5b09dfbd6b742e5c8: received unexpected HTTP status: 500 Internal Server Error

Trying one more time...

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2020
@awgreene
Copy link
Member Author

/retest

@awgreene
Copy link
Member Author

/test e2e-gcp-upgrade

1 similar comment
@awgreene
Copy link
Member Author

/test e2e-gcp-upgrade

@awgreene
Copy link
Member Author

/retest

6 similar comments
@awgreene
Copy link
Member Author

/retest

@awgreene
Copy link
Member Author

/retest

@awgreene
Copy link
Member Author

/retest

@ecordell
Copy link
Member

/retest

@awgreene
Copy link
Member Author

/retest

@ecordell
Copy link
Member

/retest

@awgreene
Copy link
Member Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2020
@awgreene
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@awgreene
Copy link
Member Author

/retest

1 similar comment
@awgreene
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 3455a00 into operator-framework:master Mar 16, 2020
@openshift-ci-robot
Copy link
Collaborator

@awgreene: All pull requests linked via external trackers have merged. Bugzilla bug 1805412 has been moved to the MODIFIED state.

In response to this:

Bug 1805412: Support multiple APIServices on a single deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 17, 2020
Closed
@openshift-cherrypick-robot
Copy link

@ecordell: new pull request created: #1382

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell left review comments

@njhale njhale njhale left review comments

@exdx exdx exdx left review comments

@harishsurf harishsurf harishsurf left review comments

@anik120 anik120 anik120 requested changes

@kevinrizza kevinrizza kevinrizza requested changes

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@ecordell ecordell

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet